Summary: | ChromeClients don't get addMessageToConsole() called for non-string arguments | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||
Component: | WebCore Misc. | Assignee: | Dimitri Glazkov (Google) <dglazkov> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | dglazkov, fishd, ml | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Mac | ||||||||||||||
OS: | OS X 10.5 | ||||||||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2009-03-10 11:52:57 PDT
Created attachment 28445 [details]
Patch, testcase, changelog
dglakzov said that FrameLoader::executeIfJavaScriptURL () may have a similar issue This will also break Chromium build, because it exposes JSValue. Perhaps we could change ScriptValue::getString() to ScriptValue::toString() which does the conversion? This should address the issue with FrameLoader::executeIfJavaScriptURL and Console::addMessage as well. +fishd as he wrote ScriptValue originally. If you don't mind, I'll reuse your awesome layout test. Created attachment 28502 [details]
Fix logging of non-string values, v2
LayoutTests/ChangeLog | 10 ++++++++++
.../fast/js/console-non-string-values-expected.txt | 7 +++++++
LayoutTests/fast/js/console-non-string-values.html | 18 ++++++++++++++++++
WebCore/ChangeLog | 19 +++++++++++++++++++
WebCore/bindings/js/ScriptValue.cpp | 1 -
WebCore/bindings/js/ScriptValue.h | 3 +++
WebCore/page/Console.cpp | 9 +++++----
7 files changed, 62 insertions(+), 5 deletions(-)
Landed as http://trac.webkit.org/changeset/41640. Created attachment 28550 [details] WebCore: 2009-03-12 Peter Kasting <pkasting@google.com> Reviewed by Darin Fisher. https://bugs.webkit.org/show_bug.cgi?id=24502 Make horizontal scrolling on Windows always go the correct direction. * platform/PlatformWheelEvent.h: * platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent): WebKit/win: 2009-03-12 Peter Kasting <pkasting@google.com> Reviewed by Darin Fisher. https://bugs.webkit.org/show_bug.cgi?id=24502 Make horizontal scrolling on Windows always go the correct direction. * WebView.cpp: (WebView::mouseWheel): (WebViewWndProc): * WebView.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41642 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- WebCore/ChangeLog | 11 +++++++++++ WebCore/platform/PlatformWheelEvent.h | 2 +- WebCore/platform/win/WheelEventWin.cpp | 6 ++++-- WebKit/win/ChangeLog | 12 ++++++++++++ WebKit/win/WebView.cpp | 6 +++--- WebKit/win/WebView.h | 2 +- 6 files changed, 32 insertions(+), 7 deletions(-) Created attachment 28551 [details] 2009-03-12 Dimitri Glazkov <dglazkov@chromium.org> Reviewed by Adam Treat. https://bugs.webkit.org/show_bug.cgi?id=24525 REGRESSION: Inspector window doesn't close when inspected page is destroyed. This is a revert of r41158, which became unnecessary when InspectorController became ref-counted in r41462. * inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedPageDestroyed): Reset m_inspectedPage after calling close(). (WebCore::InspectorController::stopUserInitiatedProfiling): Remove m_inspectedPage check guard around profile logic. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41643 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- WebCore/ChangeLog | 15 +++++++++++++++ WebCore/inspector/InspectorController.cpp | 14 ++++++-------- 2 files changed, 21 insertions(+), 8 deletions(-) Created attachment 28552 [details]
Do the same for V8 bindings.
WebCore/ChangeLog | 15 +++++++++++++++
WebCore/bindings/v8/ScriptValue.cpp | 5 +++++
WebCore/bindings/v8/ScriptValue.h | 6 ++++--
3 files changed, 24 insertions(+), 2 deletions(-)
I should do the same changes for V8 bindings. doh. Comment on attachment 28552 [details]
Do the same for V8 bindings.
LGTM
V8 changes landed as http://trac.webkit.org/changeset/41649. |