Bug 24491

Summary: Rename posOffset to m_offset, get rid of accessor
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: DOMAssignee: Nobody <webkit-unassigned>
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Description Flags
posoffset.patch darin: review+

Description Xan Lopez 2009-03-10 08:31:54 PDT
As suggested in dom/Position.h, this patch gets rid of the 'offset()' accessor and renames posOffset to m_offset. I've used m_offset instead of offset to follow the style guide lines, since Position is still a class and not a structure. If the long term plan is still to make it a structure it would be pretty easy to just s/m_offset/offset/ globally when that is achieved.
Comment 1 Xan Lopez 2009-03-10 08:34:37 PDT
Created attachment 28437 [details]
Comment 2 Darin Adler 2009-03-10 09:05:57 PDT
Comment on attachment 28437 [details]

Seems fine, r=me
Comment 3 Xan Lopez 2009-03-10 09:12:00 PDT
Thanks, landed in r41553.