Bug 24484
| Summary: | Amalgamate separate overflowHeight etc. methods to avoid lots of hash lookups in RenderReplaced | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | hyatt, jchaffraix, mitz |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
Simon Fraser (smfr)
If a RenderReplaced has overflow, it has to do a hash lookup for each call to overflowHeight(), overflowWidth(), overflowLeft(), overflowTop() and overflowRect().
We should use fewer methods that return IntSizes etc. to avoid all these hash lookups.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Julien Chaffraix
It looks like the overflow logic has been refactored since this bug was opened and we don't have a hash lookup for any RenderReplaced overflow functions anymore.
Simon, is there something to be saved of it or should we just close it?
Julien Chaffraix
Oops, I did not mean to close it. Feel free to reopen if there is something to be saved.