Bug 24482 – REGRESSION (r38635): JavaScript error using Oneida wedding registry page

• Component: WebCore JavaScript
• Status: RESOLVED DUPLICATE

[David Kilzer (:ddkilzer)]

* SUMMARY
The Oneida registry page has a ship-to address form that contains JavaScript to ensure that the address lines are not more than 26 characters long.  This works in Safari 3.2.x, but fails in Safari 4 Public Beta and in the latest WebKit nightly build (r41521).

* STEPS TO REPRODUCE
1. Register for an account on <http://www.oneida.com/>.
2. On the register page, hit Cmd-Opt-C to open the Web Inspector.  The following error is printed in the console:  "TypeError: Result of expression 'wishListCreateFormFormObj.address1.validateLengthLT' [undefined] is not a function."
3. Fill out Ship-To address, using an address line longer than 26 characters.
4. Hit "Save" button.

* RESULTS
The page is submitting (instead of displaying an alert message), and an error page is printed instead.

* REGRESSION
This is a regression from Safari 3.2.x.

* NOTES
The bisect-builds script reports:

Works: r38592  Fails: r38645

[David Kilzer (:ddkilzer)]

Looks like the validateLengthLT() function is part of the qForms library:

http://www.hollins.edu/qforms/docs/extension_validation.htm#validateLengthLT

[David Kilzer (:ddkilzer)]

<rdar://problem/6663472>

[David Kilzer (:ddkilzer)]

An internal bisect reveals:

Works: r38632  Fails: r38635

[David Kilzer (:ddkilzer)]

Looks like more fall-out from r38635:

http://trac.webkit.org/changeset/38635

I will create a reduced (offline) test case.

[David Kilzer (:ddkilzer)]

Created attachment 28426 [details]
Offline test case

This is an offline test case that reproduces the issue.  It could be reduced (much) further.

[Cameron Zwarich (cpst)]

I'll take this bug.

[Cameron Zwarich (cpst)]

As I sort of expected, this is a dupe of bug 24291 and is fixed by my patch there. I'll make some tests and put it up for review.

*** This bug has been marked as a duplicate of 24291 ***