Bug 244782 – [LFC][IFC] Move overflowing float boxes to the next line

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

ssia

[alan]

Created attachment 462131 [details]
Patch

[alan]

Created attachment 462132 [details]
Patch

[alan]

Created attachment 462134 [details]
Patch

[Antti Koivisto]

Comment on attachment 462134 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462134&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:937
> +        // we can still continue placing inline content on the line, but we have to save all the upcoming floats for subsequent lines.
> +        auto lineHasSkippedFloats = !m_overflowingFloats.isEmpty();
> +        if (lineHasSkippedFloats)
> +            return false;
> +        if (lineBoxConstraintApplies == LineBoxConstraintApplies::No) {
> +            // This is an overflowing float from previous line. Now we need to find a place for it.
> +            return true;
> +        }

maybe we can assert these conditions are mutually exclusive

[alan]

(In reply to Antti Koivisto from comment #4)
> Comment on attachment 462134 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=462134&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:937
> > +        // we can still continue placing inline content on the line, but we have to save all the upcoming floats for subsequent lines.
> > +        auto lineHasSkippedFloats = !m_overflowingFloats.isEmpty();
> > +        if (lineHasSkippedFloats)
> > +            return false;
> > +        if (lineBoxConstraintApplies == LineBoxConstraintApplies::No) {
> > +            // This is an overflowing float from previous line. Now we need to find a place for it.
> > +            return true;
> > +        }
> 
> maybe we can assert these conditions are mutually exclusive
good idea!

[alan]

Created attachment 462145 [details]
Patch

[EWS]

Committed 254170@main (9f5be0d75394): <https://commits.webkit.org/254170@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462145 [details].

[Radar WebKit Bug Importer]

<rdar://problem/99578693>