Summary: | history.length does not return number of elements in history list | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Manuel Deschamps <manueldeschamps> | ||||
Component: | DOM | Assignee: | Darin Fisher (:fishd, Google) <fishd> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | beidson, eric, fishd, just1gb, sam, vicki | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 525.x (Safari 3.2) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Manuel Deschamps
2009-03-09 15:56:49 PDT
Confirming. This is a bug per spec, and it seems like WebKit really should match IE and FF here. I'm happy to write a patch for this if there are no objections to changing WebKit's behavior. No brainer. Do it. Created attachment 46703 [details]
v1 patch
Comment on attachment 46703 [details]
v1 patch
r+
Landed as http://trac.webkit.org/changeset/53346 Looks like this is failing on Leopard: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r53346%20(9430)/fast/history/history-length-pretty-diff.html I think you already mentioned that in IRC, but wanted to record it here in case you hadn't noticed. Darin is not online or in his office. I'm going to roll out this change to fix the builders. He can roll it back in with the test fixed. Darin disabled the test in http://trac.webkit.org/changeset/53348 so the builders should roll green. *** Bug 14499 has been marked as a duplicate of this bug. *** It doesn't look like the patch was rolled out, after all. And the test has been fixed, too. Does the bug need to remain open for some reason? This bug should be updated with the revision of the fix, but certainly doesn't need to stay open on my account. :) Yeah, I fixed the test. See https://bugs.webkit.org/show_bug.cgi?id=33749 for details. |