Bug 244687

Summary: AX ITM: pass Ref<AXCoreObject> to live objects by reference.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: AccessibilityAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, tyler_w, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Andres Gonzalez 2022-09-01 14:32:17 PDT 
Follow up to patch in https://bugs.webkit.org/show_bug.cgi?id=241810.
Comment 1 Radar WebKit Bug Importer 2022-09-01 14:32:29 PDT 
<rdar://problem/99457705>
Comment 2 Andres Gonzalez 2022-09-01 14:45:02 PDT 
Created attachment 462080 [details]
Patch
Comment 3 Andres Gonzalez 2022-09-01 18:08:14 PDT 
Created attachment 462082 [details]
Patch
Comment 4 Tyler Wilcock 2022-09-01 19:08:43 PDT 
Comment on attachment 462082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462082&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:273
> +        AXLOG(axObject.ptr());

I think (but am not 100% sure) this will only log the memory address of the object. Does axObject.get() (which returns a reference) compile?
Comment 5 Andres Gonzalez 2022-09-02 05:21:00 PDT 
(In reply to Tyler Wilcock from comment #4)
> Comment on attachment 462082 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=462082&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:273
> > +        AXLOG(axObject.ptr());
> 
> I think (but am not 100% sure) this will only log the memory address of the
> object. Does axObject.get() (which returns a reference) compile?

No, AXLogger::log takes a pointer not a reference, so you need ptr().
Comment 6 EWS 2022-09-02 12:22:07 PDT 
Committed 254107@main (276e9d6f7b36): <https://commits.webkit.org/254107@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462082 [details].