Bug 244621
| Summary: | GCC does not have an error maximum, breaking EWS on bad patches | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Elliott Williams <emw> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Elliott Williams
For example: https://github.com/WebKit/WebKit/commit/fdc83ec3c441df44f9e272d1426baa01fdb287fe introduced errors in the WPE build, and caused https://ews-build.webkit.org/#/builders/8/builds/96909 to spend > 5 hrs compiling, generating millions of lines of output. 99% of those lines were error output, and there were 100k errors emitted in total.
Clang avoids explosive situations like this by bailing out after 20 errors (configurable by the -ferror-limit=<n> option). GCC doesn't have an error limit by default, but one can be configured using -fmax-errors=<n>. We should use this to match GCC's behavior to clang's.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/3870
EWS
Committed 254063@main (c331d47aa73c): <https://commits.webkit.org/254063@main>
Reviewed commits have been landed. Closing PR #3870 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/99453998>