Bug 244524
| Summary: | make_names.pl findTagName trie search code could be improved | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Cameron McCormack (:heycam) <heycam> |
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 244768 | ||
| Bug Blocks: | |||
Cameron McCormack (:heycam)
Two suggestions that came out of the bug 244020 review:
1. When reaching the leaf of the trie, the suffix to compare against could be a string literal rather than an array of characters.
2. We sometimes put braces around single statements.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Cameron McCormack (:heycam)
3. The generated code sometimes includes a sequence of single character if statement checks. These should be combined into a single memcmp.
Radar WebKit Bug Importer
<rdar://problem/99580507>