Bug 244459

Summary: AX: Only cache and update AXPropertyName::IdentifierAttribute if !LOG_DISABLED
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Tyler Wilcock 2022-08-28 19:52:57 PDT
We do expose AXDOMIdentifier, but it's only called by tests and not real AX clients, so we shouldn't spend the time caching and updating it unless logging is enabled (for debugging purposes).
Comment 1 Radar WebKit Bug Importer 2022-08-28 19:53:07 PDT
<rdar://problem/99259089>
Comment 2 Tyler Wilcock 2022-08-28 20:14:27 PDT
Created attachment 461960 [details]
Patch
Comment 3 Tyler Wilcock 2022-08-28 20:17:06 PDT
Created attachment 461961 [details]
Patch
Comment 4 EWS 2022-08-29 11:35:59 PDT
Committed 253917@main (95cb4d36cc5a): <https://commits.webkit.org/253917@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461961 [details].