Bug 244374
| Summary: | Unify copies of SDKVariant.xcconfig | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | WebCore Misc. | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, ryanhaddad, thorton, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 244440, 244450 | ||
David Kilzer (:ddkilzer)
Unify copies of SDKVariant.xcconfig.
Create a `Source/Configurations` folder and move one copy of `SDKVariant.xcconfig` into it, then remove the duplicate copies, then finally fix project references to use relative paths.
The `Source/Configurations` folder is added to the WebKit.xcworkspace as well (since we can move other common files into this folder later).
We place this in `Source` instead of in the top-level folder since it will make source submissions easier at Apple.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/99169843>
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/3688
EWS
Committed 253857@main (024ecd89c769): <https://commits.webkit.org/253857@main>
Reviewed commits have been landed. Closing PR #3688 and removing active labels.
David Kilzer (:ddkilzer)
(In reply to David Kilzer (:ddkilzer) from comment #0)
> Unify copies of SDKVariant.xcconfig.
>
> Create a `Source/Configurations` folder and move one copy of
> `SDKVariant.xcconfig` into it, then remove the duplicate copies, then
> finally fix project references to use relative paths.
>
> The `Source/Configurations` folder is added to the WebKit.xcworkspace as
> well (since we can move other common files into this folder later).
>
> We place this in `Source` instead of in the top-level folder since it will
> make source submissions easier at Apple.
FYI, the `Configurations` folder was placed at the same level as the `Source` folder since there was a simple change to `Makefile` to make source submissions work.