Bug 24432

Summary: Unify JSC/V8 DOMWindow.idl
Product: WebKit Reporter: Mike Belshe <mbelshe>
Component: WebCore JavaScriptAssignee: Mike Belshe <mbelshe>
Status: RESOLVED FIXED    
Severity: Normal CC: sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
patch eric: review+

Description Mike Belshe 2009-03-06 14:17:28 PST 
There is no difference in functionality between JSC and V8.

Here are the changes:
* V8 implements shadowing in a different way from JSC; properties which cannot be shadowed add the V8DisallowShadowing attribute.
* JSC omits several properties from the IDL and adds them directly from JSDOMWindowBase.  V8 needs them here so they can be generated.

This change should have no effect on JSC, and both pass the layout tests.
Comment 1 Mike Belshe 2009-03-06 14:21:11 PST 
Created attachment 28372 [details]
patch
Comment 2 Eric Seidel (no email) 2009-03-06 18:49:23 PST 
Comment on attachment 28372 [details]
patch

Looks fine to me.  I'll again CC sam so he sees this go through his inbox.
Comment 3 Eric Seidel (no email) 2009-03-09 12:48:29 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/page/DOMWindow.idl
Committed r41533