Bug 244292
| Summary: | test-webkitpy --all failures on main | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | fujii.hironori, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=245810 https://bugs.webkit.org/show_bug.cgi?id=248305 https://bugs.webkit.org/show_bug.cgi?id=248304 |
||
Sam Sneddon [:gsnedders]
There's quite a lot there :(
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Sneddon [:gsnedders]
Pull request: https://github.com/WebKit/WebKit/pull/3603
EWS
Committed 253880@main (74b1edfb3f78): <https://commits.webkit.org/253880@main>
Reviewed commits have been landed. Closing PR #3603 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/99250197>
Jonathan Bedard
Re-opening for pull request https://github.com/WebKit/WebKit/pull/3889
EWS
Committed 254020@main (a12e01f79c67): <https://commits.webkit.org/254020@main>
Reviewed commits have been landed. Closing PR #3889 and removing active labels.
EWS
Committed 252432.352@safari-7614-branch (8af621e21b22): <https://commits.webkit.org/252432.352@safari-7614-branch>
Reviewed commits have been landed. Closing PR #45 and removing active labels.
EWS
Committed 252432.353@safari-7614-branch (f7ec3ecb02a6): <https://commits.webkit.org/252432.353@safari-7614-branch>
Reviewed commits have been landed. Closing PR #46 and removing active labels.
Fujii Hironori
Adding '--all' switch is causing a problem for WinCairo buildbot (bug#245811).
Why don't you just unskip some tests?
https://github.com/WebKit/WebKit/blob/main/Tools/Scripts/webkitpy/test/main.py#L77
Can I revert the '--all' switch part of the patch?
Fujii Hironori
Reopen to revert.
Fujii Hironori
Pull request: https://github.com/WebKit/WebKit/pull/5000
EWS
Committed 255219@main (7934e56e257a): <https://commits.webkit.org/255219@main>
Reviewed commits have been landed. Closing PR #5000 and removing active labels.
Sam Sneddon [:gsnedders]
Re-opening for pull request https://github.com/WebKit/WebKit/pull/6785
Sam Sneddon [:gsnedders]
*** Bug 248305 has been marked as a duplicate of this bug. ***
Fujii Hironori
https://github.com/WebKit/WebKit/pull/5000#discussion_r988018816
> We can remove SVN tests, and probably git ones too, actually, since most of our git tooling lives in webkitscmpy now, which takes a different approach to testing than webkitpy
> That being said, feels like the most immediate task is just the revert, we can clean up in future changes.
Can we remove them?
Sam Sneddon [:gsnedders]
(In reply to Fujii Hironori from comment #14)
> https://github.com/WebKit/WebKit/pull/5000#discussion_r988018816
>
> > We can remove SVN tests, and probably git ones too, actually, since most of our git tooling lives in webkitscmpy now, which takes a different approach to testing than webkitpy
> > That being said, feels like the most immediate task is just the revert, we can clean up in future changes.
>
> Can we remove them?
I'd rather do these in separate PRs, in case we need to revert any of this again.
EWS
Committed 257437@main (73bf03b537e5): <https://commits.webkit.org/257437@main>
Reviewed commits have been landed. Closing PR #6785 and removing active labels.