Bug 244279
| Summary: | Remove hspace and vspace attributes from input field | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Forms | Assignee: | Karl Dubost <karlcow> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, bfulgham, cdumez, karlcow, rniwa, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar, WPTImpact |
| Version: | Safari 15 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | http://wpt.live/html/rendering/unmapped-attributes.html | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=120133 | ||
Ahmad Saleem
Hi Team,
Similar to bug 120133, we are still failing test cases on WPT:
Link - https://wpt.fyi/results/html/rendering/unmapped-attributes.html?label=experimental&label=master&aligned
Example - <input hspace> should not be mapped to style marginLeft in CSS1Compat mode
Just wanted to create a bug since I was not able to find any.
NOTE - Safari Technology Preview 151 and Chrome Canary 107 both are failing these tests while Firefox Nightly 106 is passing them.
If it is similar to bug 120133, I am happy to give it a try.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
https://github.com/WebKit/WebKit/pull/3598
Ahmad Saleem
I closed this pull request since it is not as simple as "Bug 120133" and these are lessons learnt:
1) Following test fails with the change (if followed to do similar to Bug 120133:
imported/w3c/web-platform-tests/html/rendering/dimension-attributes.html
^ This expects you to have "vspace" and "hspace" available for input type = image and not for others.
2) WPT Test case wording is wrong and it just states "input vspace" while it should be "input type=image vspace" to make it more clearer that it is an edge case.
3) m_inputType need to introduced within HTMLInputElement to look for any Input type which is Image and only then apply this vspace and hspace attributes. Since I am still lacking in learning about Webkit, Programming and C++, so I think someone else need to take this up.
______
Just wanted to share learnings before I make this available for others and close my pull requests. Thanks!
Radar WebKit Bug Importer
<rdar://problem/99356718>
Karl Dubost
Pull request: https://github.com/WebKit/WebKit/pull/8083
Karl Dubost
I may have found a way to deal with it.
Let's see what EWS testing says in the pull request
https://github.com/WebKit/WebKit/pull/8083
EWS
Committed 258360@main (90658791ba8b): <https://commits.webkit.org/258360@main>
Reviewed commits have been landed. Closing PR #8083 and removing active labels.