Bug 244259
Summary: | [ews] Duplicate Github status-bubbles for old hash on PRs | ||
---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> |
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | Other | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Aakash Jain
[ews] Duplicate Github status-bubbles for old hash on PRs. When a new commit is pushed to an old PR (older than when GitHub status-bubbles were launched), ews also creates status-bubbles for older pushes on that PRs. However, it doesn't store the comment id for those comments (for older commits). So, next time another commit is pushed to that PR, status-bubbles are duplicated for all the older commits.
e.g.: https://github.com/WebKit/WebKit/pull/2677#issuecomment-1224558257 and https://github.com/WebKit/WebKit/pull/2677#issuecomment-1224558257
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Aakash Jain
Pull request: https://github.com/WebKit/WebKit/pull/3583
EWS
Committed 253692@main (f6b0e3a9159a): <https://commits.webkit.org/253692@main>
Reviewed commits have been landed. Closing PR #3583 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/99046572>