Bug 244205
| Summary: | Fix invalid %{public} %{private} format strings in cross-platform code | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, webkit-bug-importer |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | All | ||
Michael Catanzaro
%{public} and %{private} are not valid format strings except on Apple platforms, and cannot be used in cross-platform code. Most uses can be replaced with the existing PUBLIC_LOG_STRING and PRIVATE_LOG_STRING.
Since not everything we log is a string, I have added PUBLIC_LOG and PRIVATE_LOG as well to allow more generic use.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
Pull request: https://github.com/WebKit/WebKit/pull/3537
EWS
Committed 254189@main (3454ee99a16d): <https://commits.webkit.org/254189@main>
Reviewed commits have been landed. Closing PR #3537 and removing active labels.