Bug 24417

Summary: [GTK] WebKitDownload's _cancel and _dispose methods may emit warnings
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: WebKitGTKAssignee: Gustavo Noronha (kov) <gustavo>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Gtk
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
proposed fix mrowe: review+

Description Gustavo Noronha (kov) 2009-03-05 17:54:09 PST 
Those calls deal with the GTimer used to keep information about download elapsed time, but the timer may never get initialized if _start is not called. If nothing handles the download-requested signal, for example, this will emit nasty warning/critical messages in the terminal.
Comment 1 Gustavo Noronha (kov) 2009-03-05 17:54:38 PST 
Created attachment 28343 [details]
proposed fix
Comment 2 Mark Rowe (bdash) 2009-03-05 20:32:27 PST 
Comment on attachment 28343 [details]
proposed fix

r=me.  "existence" is misspelt in the ChangeLog, the comma is unnecessary there too, and perhaps the comments in the code could be a little more consistent (exists vs non-NULL).
Comment 3 Gustavo Noronha (kov) 2009-03-06 05:24:54 PST 
Landed as r41478.