Bug 244116

Summary: [git-webkit] `git-webkit pr` gets confused with commit titles with backticks
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 239082    

Tim Nguyen (:ntim)
Reported 2022-08-18 22:01:16 PDT
ntim @ OpenSource ⚡️ git-webkit pr Branch 'main' set up to track remote branch 'main' from 'origin'. Found 1 commit... Found 2 commits... ERROR: Unexpected diff format when parsing a chunk: 'From ff2fb44dfeff2d7f6958e527ad0e8a451aec3b08 Mon Sep 17 00:00:00 2001' ERROR: Unexpected diff format when parsing a chunk: 'From: Tim Nguyen <ntim@apple.com>' ERROR: Unexpected diff format when parsing a chunk: 'Date: Thu, 18 Aug 2022 21:47:34 -0700' ERROR: Unexpected diff format when parsing a chunk: 'Subject: [PATCH 2/2] Rename initial value of color-scheme from `auto` to' ERROR: Unexpected diff format when parsing a chunk: 'Reviewed by NOBODY (OOPS!).' ERROR: Unexpected diff format when parsing a chunk: '* LayoutTests/css-dark-mode/color-scheme-css-parse.html:' ERROR: Unexpected diff format when parsing a chunk: '* LayoutTests/css-dark-mode/color-scheme-css-expected.txt:' ERROR: Unexpected diff format when parsing a chunk: '* LayoutTests/css-dark-mode/color-scheme-css.html:' ERROR: Unexpected diff format when parsing a chunk: '* LayoutTests/css-dark-mode/older-syntax/supported-color-schemes-css-expected.txt:' ERROR: Unexpected diff format when parsing a chunk: '* LayoutTests/css-dark-mode/older-syntax/supported-color-schemes-css.html:' ERROR: Unexpected diff format when parsing a chunk: '* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/inheritance-expected.txt:' ERROR: Unexpected diff format when parsing a chunk: '* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-attribute-changes-expected.txt:' ERROR: Unexpected diff format when parsing a chunk: '* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-empty-content-value-expected.txt:' ERROR: Unexpected diff format when parsing a chunk: '* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-first-valid-applies-expected.txt:' ERROR: Unexpected diff format when parsing a chunk: '* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-insert-expected.txt:' ERROR: Unexpected diff format when parsing a chunk: '* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-no-content-value-expected.txt:' ERROR: Unexpected diff format when parsing a chunk: '* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-remove-expected.txt:' ERROR: Unexpected diff format when parsing a chunk: '* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-remove-head-expected.txt:' ERROR: Unexpected diff format when parsing a chunk: '* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-single-value-in-body-expected.txt:' ERROR: Unexpected diff format when parsing a chunk: '* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-single-value-in-head-expected.txt:' ERROR: Unexpected diff format when parsing a chunk: '* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-single-value-in-shadow-tree-expected.txt:' ERROR: Unexpected diff format when parsing a chunk: '* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/parsing/color-scheme-computed-expected.txt:' ERROR: Unexpected diff format when parsing a chunk: '* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/parsing/color-scheme-invalid-expected.txt:' ERROR: Unexpected diff format when parsing a chunk: '* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/parsing/color-scheme-valid-expected.txt:' ERROR: Unexpected diff format when parsing a chunk: '* Source/WebCore/css/CSSComputedStyleDeclaration.cpp:' ERROR: Unexpected diff format when parsing a chunk: '(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):' ERROR: Unexpected diff format when parsing a chunk: '* Source/WebCore/css/CSSProperties.json:' ERROR: Unexpected diff format when parsing a chunk: '* Source/WebCore/css/CSSValueKeywords.in:' ERROR: Unexpected diff format when parsing a chunk: '* Source/WebCore/css/parser/CSSPropertyParser.cpp:' ERROR: Unexpected diff format when parsing a chunk: '(WebCore::consumeColorScheme):' ERROR: Unexpected diff format when parsing a chunk: '* Source/WebCore/rendering/style/StyleColorScheme.h:' ERROR: Unexpected diff format when parsing a chunk: '(WebCore::StyleColorScheme::isNormal const):' ERROR: Unexpected diff format when parsing a chunk: '(WebCore::StyleColorScheme::isAuto const): Deleted.' Total errors found: 0 in 43 files Enumerating objects: 71, done. Counting objects: 100% (71/71), done. Delta compression using up to 8 threads Compressing objects: 100% (39/39), done. Writing objects: 100% (42/42), 5.18 KiB | 1.04 MiB/s, done. Total 42 (delta 30), reused 11 (delta 2), pack-reused 0 remote: Resolving deltas: 100% (30/30), completed with 27 local objects. remote: remote: Create a pull request for 'color-scheme-normal' on GitHub by visiting: remote: https://github.com/nt1m/WebKit/pull/new/color-scheme-normal remote: To github.com:nt1m/WebKit.git * [new branch] color-scheme-normal -> color-scheme-normal Created 'PR 3471 | Re'! Posted pull request link to https://bugs.webkit.org/show_bug.cgi?id=205799 https://github.com/WebKit/WebKit/pull/3471
Attachments
Radar WebKit Bug Importer
Comment 1 2022-08-25 22:02:15 PDT
Jonathan Bedard
Comment 2 2023-09-15 11:42:46 PDT
*** This bug has been marked as a duplicate of bug 240874 ***
Note You need to log in before you can comment on or make changes to this bug.