Bug 24409 – re-work layer destruction to clear m_renderer and m_layer after destruction

• Component: CSS
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

re-work layer destruction to clear m_renderer and m_layer after destruction

This work was initially inspired by:
http://code.google.com/p/chromium/issues/detail?id=7829

I don't know that this will actually help us track down that crash, but I do think that it is cleanup worth doing.

[Eric Seidel (no email)]

Created attachment 28332 [details]
Changes to RenderLayer destruction to hopefully help catch an ellusive crasher

 WebCore/ChangeLog                          |   26 ++++++++++++++++++++++++++
 WebCore/rendering/RenderBox.cpp            |    2 +-
 WebCore/rendering/RenderBoxModelObject.cpp |   20 +++++++++++++++-----
 WebCore/rendering/RenderBoxModelObject.h   |    5 ++++-
 WebCore/rendering/RenderLayer.cpp          |   17 ++++++++---------
 WebCore/rendering/RenderLayer.h            |    6 ++++--
 WebCore/rendering/RenderObject.cpp         |    5 ++---
 WebCore/rendering/RenderWidget.cpp         |   17 ++++++++---------
 8 files changed, 68 insertions(+), 30 deletions(-)

[Dave Hyatt]

Comment on attachment 28332 [details]
Changes to RenderLayer destruction to hopefully help catch an ellusive crasher

r=me. Make sure to test thoroughly, though, since you have changed the timing of stuff (especially in RenderWidget).

[Eric Seidel (no email)]

(In reply to comment #2)
> (From update of attachment 28332 [details] [review])
> r=me. Make sure to test thoroughly, though, since you have changed the timing
> of stuff (especially in RenderWidget).

I've run all of the layout tests, full pass.

[Eric Seidel (no email)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/rendering/RenderBox.cpp
	M	WebCore/rendering/RenderBoxModelObject.cpp
	M	WebCore/rendering/RenderBoxModelObject.h
	M	WebCore/rendering/RenderLayer.cpp
	M	WebCore/rendering/RenderLayer.h
	M	WebCore/rendering/RenderObject.cpp
	M	WebCore/rendering/RenderWidget.cpp
Committed r41469