Bug 244038
| Summary: | Make css/css-scroll-snap/scroll-target-margin-005.html pass | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> |
| Component: | Scrolling | Assignee: | Nikos Mouchtaris <nmouchtaris> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Tim Nguyen (:ntim)
There are 3 issues:
- The focus() ScrollRectToVisibleOptions does not match the scrollIntoView() one
- The test uses <input type="date">, which redirects focus inside the UA shadow root, so we don't take in account the shadow host scroll margin
- The test should wait for a tick, since scrolling to the focused element doesn't happen immediately in WebKit
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Tim Nguyen (:ntim)
Pull request: https://github.com/WebKit/WebKit/pull/3412
Radar WebKit Bug Importer
<rdar://problem/99087807>
Nikos Mouchtaris
Pull request: https://github.com/WebKit/WebKit/pull/3673
EWS
Committed 254195@main (a728674047d7): <https://commits.webkit.org/254195@main>
Reviewed commits have been landed. Closing PR #3673 and removing active labels.