Bug 244033

Summary: [LFC][IFC] Add support for out-of-flow content
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, ntim, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=244787
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

alan
Reported 2022-08-17 08:26:02 PDT
ssia
Attachments
Patch (16.84 KB, patch)
2022-08-17 08:35 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (17.08 KB, patch)
2022-08-17 10:07 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (18.72 KB, patch)
2022-08-17 16:45 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (19.56 KB, patch)
2022-08-17 16:51 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (22.45 KB, patch)
2022-08-20 07:45 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (22.61 KB, patch)
2022-08-20 11:02 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (22.62 KB, patch)
2022-08-20 22:32 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2022-08-17 08:35:04 PDT
Created attachment 461692 [details] Patch
alan
Comment 2 2022-08-17 10:07:52 PDT
Created attachment 461693 [details] Patch
Antti Koivisto
Comment 3 2022-08-17 10:28:39 PDT
Comment on attachment 461693 [details] Patch very nice
Antti Koivisto
Comment 4 2022-08-17 10:31:37 PDT
Comment on attachment 461693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=461693&action=review > Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:268 > +static inline std::tuple<const InlineDisplay::Box*, const InlineDisplay::Box*> previousAndNextDisplayBox(const Box& outOfFlowBox, const DisplayBoxes& displayBoxes) 'inline' is probably unnecessary This sound rather generic, maybe it could be something like previousAndNextDisplayBoxForStaticPosition?
alan
Comment 5 2022-08-17 16:45:04 PDT
Created attachment 461700 [details] Patch
alan
Comment 6 2022-08-17 16:51:21 PDT
Created attachment 461701 [details] Patch
alan
Comment 7 2022-08-20 07:45:14 PDT
Created attachment 461761 [details] Patch
alan
Comment 8 2022-08-20 11:02:19 PDT
Created attachment 461767 [details] Patch
Tim Nguyen (:ntim)
Comment 9 2022-08-20 11:39:11 PDT
Comment on attachment 461767 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=461767&action=review > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:374 > + auto isSpportedFloatingOrPositioned = [&] (auto& renderer) { typo: isSupportedFloatingOrPositioned
alan
Comment 10 2022-08-20 22:32:38 PDT
Created attachment 461776 [details] Patch
EWS
Comment 11 2022-08-21 07:27:28 PDT
Committed 253628@main (669ac300289c): <https://commits.webkit.org/253628@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461776 [details].
Radar WebKit Bug Importer
Comment 12 2022-08-21 07:28:16 PDT
<rdar://problem/98945681>
Note You need to log in before you can comment on or make changes to this bug.