Summary: | When Inspector is docked, selection cause the page to scroll | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Timothy Hatcher <timothy> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ain, alexanderkahn, boards, bweinstein, darin, farukates, hyatt, jimmy, jon.evans, pmuellr, rik, timothy | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Joseph Pecoraro
2009-03-05 14:27:12 PST
I'm unable to reproduce this on r41844 on a Mac. I wonder if there are some other conditions that need to be made to get this to happen. Any other thoughts? Video Demo of Text Selection Uncontrolled Scolling with Inspector Open: http://screencast.com/t/VEA864MtwwT Video Demo of Typing in Textarea and Uncontrolled Scrolling with Inspector Open: http://screencast.com/t/VBMcxSPa Clarify Text Selection: I should be more clear. Double Click Text Selection is fine, its only "click and drag" selection that seems to produce the problem. Maybe, with the two different video demos I have these should be 2 bugs or this 1 should be renamed to "Unexpected (and Uncontrollable) Scrolling Behavior when Web Inspector is Open." This only happens when the Web Inspector is docked. Yup, was just going to say, works fine when undocked, reproduceable when docked. This happens while docked because the Web Inspector is a WebView inside another WebView with the WebFrameView of the main page at a shorter size. *** Bug 29208 has been marked as a duplicate of this bug. *** This is a very troublesome bug for me. It actually makes the Web Inspector a lot less useful for certain kinds of testing/development. For example, I'm testing a form that submits using AJAX. So I would like to enter some values in the form's fields, click submit, and read my debug messages in the console. But entering any text in a form field, or tabbing to the next field causes the browser to scroll to the bottom of the page, obscuring the field I am focused in. I can type, but I can't see the field anymore. So for this I either have to use Firefox with Firebug, or close and open the Web Inspector before and after each form submission. I'd prefer to just leave the Inspector open all the time. If it were up to me I'd raise this up to 'Normal' importance. This looks to be a Mac only bug, doesn't reproduce on Windows. Created attachment 42814 [details]
Screenshot demonstrating erratic scroll behavior with pull-down menus.
Also occurs when a pull-down menu (such as a SELECT element) is activated when the inspector is open.
To reproduce:
1) Go to Google Language Tools
2) Open the Inspector
3) Click the "My Language:" pull-down under the "Search for:" box
4) Observe out-of-control scrolling (including display of the expanded pull-down menu above the top of the screen, as shown)
*** Bug 31735 has been marked as a duplicate of this bug. *** *** Bug 33845 has been marked as a duplicate of this bug. *** I have a fix I am testing. This regressed with r44379, a change Darin made for viewless WebKit. http://trac.webkit.org/changeset/44379/trunk/WebKit/mac/WebCoreSupport/WebChromeClient.mm The scrollRect.move(scrollView->scrollOffset()); call to convert the rect assumes the frame view is the same size as the WebView. Using the NSView convertRect:fromView: fixes it. But I think we also do a reducdant scroll here, since WebCore already scrolls the main frame. Patch forthcoming. Created attachment 46983 [details]
Proposed Patch
I'd like Darin or Hyatt to review this, since they touched this code in the past.
I meant a "a redundant scroll". Comment on attachment 46983 [details]
Proposed Patch
Why did you dump the _usesDocumentViews code path?
Comment on attachment 46983 [details]
Proposed Patch
Oh, OK. I read the comments. I'll try to review tomorrow if no one has looked at it by now.
Comment on attachment 46983 [details]
Proposed Patch
OK, seems fine to me too.
Landed in r53556. |