Bug 24400 – Remove "start", "end", "loopStart", "loopEnd", "currentLoop", and "playCount" media element attributes

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Eric Carlson]

The "start" and "end" attributes have been removed from the HTML5 spec.

The "loopStart", "loopEnd", "currentLoop", and "playCount" attributes have been replaced by "loop".

[Eric Carlson]

Created attachment 28322 [details]
proposed patch

[Simon Fraser (smfr)]

Comment on attachment 28322 [details]
proposed patch


>  2009-03-04  Simon Fraser  <[e-mail]>
>  
>          Rubber-stamped by Eric Seidel.

Lots of removed changelogs here.

> Index: LayoutTests/media/video-loop-expected.txt
> ===================================================================
> +EXPECTED (media.currentTime == '8.399999618530273') OK

Seems like this might be sensitive to platform floating point rounding issues.
Is there a more reliable way to test it?

> Index: LayoutTests/media/video-seek-past-end-paused-expected.txt
> ===================================================================
> --- LayoutTests/media/video-seek-past-end-paused-expected.txt	(revision 41447)
> +++ LayoutTests/media/video-seek-past-end-paused-expected.txt	(working copy)
> @@ -1,9 +1,18 @@
>  Test that seeking paused video past it's duration time sets currentTime to duration and leaves video paused.
>  
> +RUN(video.src = 'content/test.mp4')
>  RUN(video.load())
> +
>  EVENT(load)
> -RUN(video.currentTime = 500)
> -EVENT(timeupdate)
> -EXPECTED (video.currentTime == '8.399999618530273') OK
> +EXPECTED (video.paused == 'true') OK
> +EXPECTED (video.ended == 'false') OK
> +RUN(video.play())
> +
> +EXPECTED (video.paused == 'false') OK
> +EXPECTED (media.currentTime > '0') OK
> +
> +EXPECTED (video.ended == 'true') OK
> +EXPECTED (media.currentTime == '8.399999618530273') OK

Ditto.

r=me if you address those issues.

[David Levin]

Previous committed <http://trac.webkit.org/changeset/41461>