Bug 243947
| Summary: | [git-webkit] `git revert` does not produce a meaningful commit message | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Elliott Williams <emw> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 239082, 241202 | ||
Elliott Williams
When you run `git revert <commit>`, the commit message generated is a blank WebKit-style commit message, and not the standard revert message from git.
I believe this is caused by https://bugs.webkit.org/show_bug.cgi?id=241202, which updated the prepare-commit-msg hook to generate better revert messages for git-webkit. `git webkit revert <identifier>` works, but I don't think we should break the normal revert workflow.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/98992367>
Brianna Fan
Pull request: https://github.com/WebKit/WebKit/pull/19135
Brianna Fan
Pull request: https://github.com/WebKit/WebKit/pull/20127
EWS
Committed 270375@main (a4e364130e7c): <https://commits.webkit.org/270375@main>
Reviewed commits have been landed. Closing PR #20127 and removing active labels.
Jonathan Bedard
Re-opening for pull request https://github.com/WebKit/WebKit/pull/20171