Bug 24389

Summary: WebKitGTK+ crashes when cancelling plugin loads
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: WebKitGTKAssignee: Gustavo Noronha (kov) <gustavo>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Gtk, Soup
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
backtrace
none
proposed fix ap: review+

Gustavo Noronha (kov)
Reported 2009-03-05 09:50:11 PST
If you go to a page that uses plugins such as flash, and click a link or cancel the load, the browser will crash. Investigating the problem I found out that our ResourceHandle implementation calls didFinishLoading in it's cancel method, which is completely bogus, the way I understand the workflow, and is not done by any other ports except for the Windows (WebCore/platform/network/win/ResourceHandleWin.cpp) port. I made a patch removing the calls to didFinishLoading, and tested with acid2, acid3, and the webkit layout tests, and found no regression. The crash is also gone.
Attachments
backtrace (25.97 KB, text/plain)
2009-03-05 09:52 PST, Gustavo Noronha (kov) 		no flags
Details
proposed fix (2.20 KB, patch)
2009-03-05 09:53 PST, Gustavo Noronha (kov) 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2009-03-05 09:52:32 PST
Created attachment 28307 [details] backtrace
Gustavo Noronha (kov)
Comment 2 2009-03-05 09:53:08 PST
Created attachment 28308 [details] proposed fix
Alexey Proskuryakov
Comment 3 2009-03-05 10:28:14 PST
Comment on attachment 28308 [details] proposed fix > + didFinishLoading here is mostly innofensive for most loads, but Typo: inoffensive. Please add a bug URL to ChangeLog. r=me
Gustavo Noronha (kov)
Comment 4 2009-03-05 10:51:45 PST
Landed as r41453.
Note You need to log in before you can comment on or make changes to this bug.