Bug 24384

Summary: Regression - Build break if ENABLE_NETSCAPE_PLUGIN_API is disabled
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: Plug-insAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: andersca, carol, kevino, norbert.leser, sam, yael
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Build fix if NETSCAPE_PLUGIN_API is disabled none

Description Laszlo Gombos 2009-03-05 08:05:10 PST 
Changeset 40505 (http://trac.webkit.org/changeset/40505) introduced a new function (jsObjectForPluginElement), which should have been guarded with the ENABLE_NETSCAPE_PLUGIN_API flag, so that WebKit ports with no plugin-support will continue to compile. 

We found this build break in the Qt port (with ENABLE_NETSCAPE_PLUGIN_API disabled), but we expect that the wx port (and possible all other ports if plug-in support disabled) is effected by this regression. (the wx port has plugin-support disabled).

Patch will follow.
Comment 1 Laszlo Gombos 2009-03-05 08:38:51 PST 
Created attachment 28303 [details]
Build fix if NETSCAPE_PLUGIN_API is disabled
Comment 2 Adam Treat 2009-03-09 10:05:35 PDT 
This was already fixed here:
http://trac.webkit.org/changeset/41451
Comment 3 Holger Freyther 2009-03-11 02:17:01 PDT 
Comment on attachment 28303 [details]
Build fix if NETSCAPE_PLUGIN_API is disabled

make it drop out of the review queue.