Bug 24384 - Regression - Build break if ENABLE_NETSCAPE_PLUGIN_API is disabled
Summary: Regression - Build break if ENABLE_NETSCAPE_PLUGIN_API is disabled
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-05 08:05 PST by Laszlo Gombos
Modified: 2009-03-11 02:17 PDT (History)
6 users (show)

See Also:

Attachments
Build fix if NETSCAPE_PLUGIN_API is disabled (1.88 KB, patch)
2009-03-05 08:38 PST, Laszlo Gombos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-03-05 08:05:10 PST 
Changeset 40505 (http://trac.webkit.org/changeset/40505) introduced a new function (jsObjectForPluginElement), which should have been guarded with the ENABLE_NETSCAPE_PLUGIN_API flag, so that WebKit ports with no plugin-support will continue to compile. 

We found this build break in the Qt port (with ENABLE_NETSCAPE_PLUGIN_API disabled), but we expect that the wx port (and possible all other ports if plug-in support disabled) is effected by this regression. (the wx port has plugin-support disabled).

Patch will follow.
Comment 1 Laszlo Gombos 2009-03-05 08:38:51 PST 
Created attachment 28303 [details]
Build fix if NETSCAPE_PLUGIN_API is disabled
Comment 2 Adam Treat 2009-03-09 10:05:35 PDT 
This was already fixed here:
http://trac.webkit.org/changeset/41451
Comment 3 Holger Freyther 2009-03-11 02:17:01 PDT 
Comment on attachment 28303 [details]
Build fix if NETSCAPE_PLUGIN_API is disabled

make it drop out of the review queue.