Bug 24382

Summary: request to add SH4 platform
Product: WebKit Reporter: Simone <simone.fiorentino>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Introduce the SH4 platform - solves the non-aligned memory accesses for SH4 in WebCore::equal ddkilzer: review+

Simone
Reported 2009-03-05 07:32:13 PST
I had some problems related to non-aligned memory accesses as done in WebCore::equal(StringImpl* string, const UChar* characters, unsigned length) function for the SH4 platform. My question is: can you add support in WebKit sources for SH4 platform? In attachment you can find a patch (against WebKit trunk) that introduce the SH4 platform and solves the non-aligned memory accesses (I use the same code as per ARM platform).
Attachments
Introduce the SH4 platform - solves the non-aligned memory accesses for SH4 in WebCore::equal (1.90 KB, patch)
2009-03-05 07:37 PST, Simone 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simone
Comment 1 2009-03-05 07:37:19 PST
Created attachment 28299 [details] Introduce the SH4 platform - solves the non-aligned memory accesses for SH4 in WebCore::equal 1. Introduce the SH4 platform 2. Solves the non-aligned memory accesses for SH4 (I use the same code as per ARM platform).
David Kilzer (:ddkilzer)
Comment 2 2009-03-05 21:03:01 PST
Comment on attachment 28299 [details] Introduce the SH4 platform - solves the non-aligned memory accesses for SH4 in WebCore::equal r=me NOTE: Need to add the bug title and bug number to the ChangeLogs before landing.
David Kilzer (:ddkilzer)
Comment 3 2009-03-05 23:18:17 PST
$ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/wtf/Platform.h M WebCore/ChangeLog M WebCore/platform/text/AtomicString.cpp Committed r41475 http://trac.webkit.org/changeset/41475
Note You need to log in before you can comment on or make changes to this bug.