Bug 243812

Summary:

Handle transform changes causing overflow updates

Product:

WebKit

Reporter:

Tim Nguyen (:ntim) <ntim>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

REOPENED

Severity:

Normal

CC:

bfulgham, changseok, commit-queue, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

248959

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
[fast-cq]Patch	none

Tim Nguyen (:ntim)

Reported 2022-08-10 20:39:26 PDT

// FIXME: transform changes really need to trigger layout. See RenderElement::adjustStyleDifference(). css/css-transforms/change-scale-wide-range.html is one affected WPT.

Attachments
Patch (4.00 KB, patch) 2022-09-10 14:58 PDT, alan	no flags	Details Formatted Diff Diff
Patch (8.45 KB, patch) 2022-10-07 19:55 PDT, alan	no flags	Details Formatted Diff Diff
Patch (8.81 KB, patch) 2022-10-07 22:00 PDT, alan	no flags	Details Formatted Diff Diff
[fast-cq]Patch (9.74 KB, patch) 2022-10-10 17:06 PDT, alan	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2022-08-10 20:39:54 PDT

<rdar://problem/98486403>

Tim Nguyen (:ntim)

Comment 2 2022-08-11 14:20:01 PDT Comment hidden (obsolete)

I think these tests are affected too: css/css-transforms/transform-transformed-tbody-contains-fixed-position.html css/css-transforms/transform-transformed-tfoot-contains-fixed-position.html css/css-transforms/transform-transformed-thead-contains-fixed-position.html

alan

Comment 3 2022-09-10 14:58:12 PDT

Created attachment 462258 [details] Patch

Tim Nguyen (:ntim)

Comment 4 2022-09-10 20:21:17 PDT

Comment on attachment 462258 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=462258&action=review > Source/WebCore/rendering/RenderElement.cpp:258 > + diff = std::max(diff, StyleDifference::SimplifiedLayout); I wonder if we can clean up code around this FIXME: https://searchfox.org/wubkat/rev/7111cbd9fd80f1b153ea0d0a1805420bae87211c/Source/WebCore/rendering/RenderLayerCompositor.cpp#1775

alan

Comment 5 2022-09-11 09:31:28 PDT

fast/repaint/multiple-backgrounds-style-change.html ^^ background image repaint optimization fails. We should certainly be able to identify this no-repaint case when there's no change in overflow.

alan

Comment 6 2022-10-07 19:55:55 PDT

Created attachment 462873 [details] Patch

alan

Comment 7 2022-10-07 22:00:54 PDT

Created attachment 462876 [details] Patch

alan

Comment 8 2022-10-10 17:06:01 PDT

Created attachment 462918 [details] [fast-cq]Patch

EWS

Comment 9 2022-10-11 14:40:36 PDT

Committed 255406@main (fc014916474a): <https://commits.webkit.org/255406@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 462918 [details].