Bug 243766

Summary:

[Painting] Add support for decorating box based text box painting

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, changseok, clopez, esprehn+autocc, ews-watchlist, glenn, gsnedders, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer, youennf, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=245209

Bug Depends on:

243526, 243564, 243575, 243576, 243577, 243610, 243611, 243619, 243621, 243632, 243647, 243712, 243732, 243752, 243756, 243762, 243765, 243792, 243921, 243922, 245209, 245316

Bug Blocks:

243928

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

zalan

Reported 2022-08-09 21:58:39 PDT

ssia

Attachments
Patch (9.53 KB, patch) 2022-08-09 22:01 PDT, zalan	no flags	Details Formatted Diff Diff
Patch (20.61 KB, patch) 2022-08-11 22:03 PDT, zalan	no flags	Details Formatted Diff Diff
Patch (23.83 KB, patch) 2022-08-12 13:21 PDT, zalan	no flags	Details Formatted Diff Diff
Patch (23.83 KB, patch) 2022-08-12 14:56 PDT, zalan	no flags	Details Formatted Diff Diff
Patch (23.83 KB, patch) 2022-08-13 06:56 PDT, zalan	no flags	Details Formatted Diff Diff
Patch (24.92 KB, patch) 2022-08-13 08:12 PDT, zalan	no flags	Details Formatted Diff Diff
Patch (24.93 KB, patch) 2022-08-13 09:59 PDT, zalan	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

zalan

Comment 1 2022-08-09 22:01:14 PDT

Created attachment 461518 [details] Patch

zalan

Comment 2 2022-08-11 22:03:37 PDT

Created attachment 461554 [details] Patch

zalan

Comment 3 2022-08-12 07:50:38 PDT

Comment on attachment 461554 [details] Patch 2 small issues still: 1, subpixel width difference on nested inline box underline 2, marked text style is ignored on propagated (nested) inline box drawing

zalan

Comment 4 2022-08-12 08:08:24 PDT

oh and vertical writing mode, that's still quite a mess.

zalan

Comment 5 2022-08-12 13:21:33 PDT

Created attachment 461566 [details] Patch

EWS Watchlist

Comment 6 2022-08-12 13:23:18 PDT

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

zalan

Comment 7 2022-08-12 14:56:51 PDT

Created attachment 461567 [details] Patch

zalan

Comment 8 2022-08-13 06:56:18 PDT

Created attachment 461575 [details] Patch

zalan

Comment 9 2022-08-13 08:12:15 PDT

Created attachment 461578 [details] Patch

zalan

Comment 10 2022-08-13 09:59:17 PDT

Created attachment 461583 [details] Patch

EWS

Comment 11 2022-08-13 22:40:20 PDT

Committed 253406@main (519c36a6ca3c): <https://commits.webkit.org/253406@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461583 [details].

Radar WebKit Bug Importer

Comment 12 2022-08-13 22:41:16 PDT

<rdar://problem/98629973>

zalan

Comment 13 2022-08-14 14:17:22 PDT

<rdar://problem/98121284&98188799&98188799&98194323&98209140&98223304&98240132&98250164&98274655&98254665&98273126&98319548&98450106&98450839&98458659&98470568&98505292&98537188&98640439&98645175>

Tim Nguyen (:ntim)

Comment 14 2022-08-14 22:38:48 PDT

*** Bug 239069 has been marked as a duplicate of this bug. ***

zalan

Comment 15 2022-08-15 08:14:45 PDT

(In reply to zalan from comment #13) > <rdar://problem/ > 98121284&98188799&98188799&98194323&98209140&98223304&98240132&98250164&98274 > 655&98254665&98273126&98319548&98450106&98450839&98458659&98470568&98505292&9 > 8537188&98640439&98645175> and rdar://problem/98468166

zalan

Comment 16 2022-09-15 16:31:19 PDT

This regressed bug 245209

zalan

Comment 17 2022-09-16 07:28:09 PDT

(In reply to zalan from comment #15) > (In reply to zalan from comment #13) > > <rdar://problem/ > > 98121284&98188799&98188799&98194323&98209140&98223304&98240132&98250164&98274 > > 655&98254665&98273126&98319548&98450106&98450839&98458659&98470568&98505292&9 > > 8537188&98640439&98645175> > and rdar://problem/98468166 and rdar://problem/99950939

zalan

Comment 18 2022-09-17 14:01:39 PDT

(In reply to zalan from comment #17) > (In reply to zalan from comment #15) > > (In reply to zalan from comment #13) > > > <rdar://problem/ > > > 98121284&98188799&98188799&98194323&98209140&98223304&98240132&98250164&98274 > > > 655&98254665&98273126&98319548&98450106&98450839&98458659&98470568&98505292&9 > > > 8537188&98640439&98645175> > > and rdar://problem/98468166 > and rdar://problem/99950939 and rdar://problem/100071411

Note You need to log in before you can comment on or make changes to this bug.