Bug 24376

Summary:

Spilt up InspectorController.cpp into separate classes

Product:

WebKit

Reporter:

Dimitri Glazkov (Google) <dglazkov>

Component:

Web Inspector (Deprecated)

Assignee:

Dimitri Glazkov (Google) <dglazkov>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

mrowe, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

24355

Attachments:

Description	Flags
Split up InspectorController, v1	timothy: review+

Dimitri Glazkov (Google)

Reported 2009-03-04 21:52:29 PST

This will become necessary once we introduce the IDL and JS bindings.

Attachments
Split up InspectorController, v1 (53.12 KB, patch) 2009-03-04 21:54 PST, Dimitri Glazkov (Google)	timothy: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dimitri Glazkov (Google)

Comment 1 2009-03-04 21:54:32 PST

Created attachment 28297 [details] Split up InspectorController, v1 WebCore/ChangeLog | 23 ++ WebCore/GNUmakefile.am | 8 + WebCore/WebCore.pro | 4 + WebCore/WebCore.scons | 4 + WebCore/WebCore.vcproj/WebCore.vcproj | 32 ++ WebCore/WebCore.xcodeproj/project.pbxproj | 32 ++ WebCore/WebCoreSources.bkl | 4 + WebCore/inspector/ConsoleMessage.cpp | 117 +++++++ WebCore/inspector/ConsoleMessage.h | 70 +++++ WebCore/inspector/InspectorController.cpp | 341 +-------------------- WebCore/inspector/InspectorDOMStorageResource.cpp | 69 +++++ WebCore/inspector/InspectorDOMStorageResource.h | 72 +++++ WebCore/inspector/InspectorDatabaseResource.cpp | 67 ++++ WebCore/inspector/InspectorDatabaseResource.h | 71 +++++ WebCore/inspector/InspectorResource.cpp | 178 +++++++++++ WebCore/inspector/InspectorResource.h | 110 +++++++ 16 files changed, 865 insertions(+), 337 deletions(-)

Dimitri Glazkov (Google)

Comment 2 2009-03-04 21:55:07 PST

I didn't do any prettying up. This is a straight split-up.

Mark Rowe (bdash)

Comment 3 2009-03-05 04:18:19 PST

Is there a reason you're using a different license header in the new files than what exists in InspectorController.cpp? I'm pretty sure you'll need to keep the existing license header.

Dimitri Glazkov (Google)

Comment 4 2009-03-05 09:03:14 PST

Oh, good point. I will update the headers before landing.

Dimitri Glazkov (Google)

Comment 5 2009-03-05 09:15:11 PST

Landed as http://trac.webkit.org/changeset/41449.

Note You need to log in before you can comment on or make changes to this bug.