Bug 243750
| Summary: | [merge-queue] validate-commit-message step rejects reviewers if spelling isn't an exact match with contributors.json | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> |
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aakash_jain, jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryan Haddad
The validate-commit-message step rejects reviewers if spelling isn't an exact match with contributors.json, e.g. here were Geoff Garen != Geoffrey Garen: https://ews-build.webkit.org/#/builders/74/builds/2279
As discussed on slack, we should drop this validation since committers are trusted people.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/98405285>
Aakash Jain
PR: https://github.com/WebKit/WebKit/pull/3168
EWS
Committed 253275@main (a25d41d0d20f): <https://commits.webkit.org/253275@main>
Reviewed commits have been landed. Closing PR #3168 and removing active labels.