Bug 243741

Summary:	[Filters] Move the static calculateOutsets functions to the FilterOperation classes
Product:	WebKit	Reporter:	Said Abou-Hallawa <sabouhallawa>
Component:	Layout and Rendering	Assignee:	Said Abou-Hallawa <sabouhallawa>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Said Abou-Hallawa 2022-08-09 11:54:22 PDT

The CSS FilterOperations have a hierarchy of base and super classes. Instead of having static calculateOutsets functions in CSSFilter.cpp for every FilterOperation we can make them virtual functions and call them through the base class FilterOperation. The only exception is ReferenceFilterOperation which requires access to the renderer and the filterElement. Accessing these classes from a platform file is a layering violation. So we still need to call calculateReferenceFilterOutsets() from CSSFilter::calculateOutsets() as a special case.

Comment 1 Said Abou-Hallawa 2022-08-09 12:05:34 PDT

Pull request: https://github.com/WebKit/WebKit/pull/3160

Comment 2 EWS 2022-08-09 22:49:28 PDT

Committed 253283@main (831f062e4ac0): <https://commits.webkit.org/253283@main>

Reviewed commits have been landed. Closing PR #3160 and removing active labels.

Comment 3 Radar WebKit Bug Importer 2022-08-09 22:50:18 PDT

<rdar://problem/98427858>