Bug 24369

Summary:

Chromium Linux: change some metrics to better match Windows

Product:

WebKit

Reporter:

Adam Langley <agl>

Component:

Layout and Rendering

Assignee:

Adam Langley <agl>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
patch	none
patch	fishd: review+

Description Adam Langley 2009-03-04 14:36:28 PST

Change some metrics to better match Windows after r41416. Aesthetically this may be worse, but web-compat is king.

Comment 1 Adam Langley 2009-03-04 14:39:04 PST

Created attachment 28285 [details]
patch

Comment 2 Adam Langley 2009-03-04 15:26:29 PST

Created attachment 28286 [details]
patch

Comment 3 Darin Fisher (:fishd, Google) 2009-03-04 16:11:37 PST

Comment on attachment 28286 [details]
patch

>+        Chromium Linux: change some metrics to better match Windows after
>+        r41416. Aesthetically this may be worse, but web-compat is king.

it is good practice to list some of the tests corresponding to this change.
it sounds like you are making some tests pass now with this change, so those
would be good tests to list here.  i think the syntax goes something like:

  Test: fast/dom/fooBar.html


otherwise, LGTM

Comment 4 Adam Langley 2009-03-04 16:15:47 PST

I rebaselined approx 3900 tests after this change, so I figured it would be better not to list them :)

Comment 5 Eric Seidel (no email) 2009-03-04 16:57:31 PST

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp
	M	WebCore/rendering/RenderThemeChromiumLinux.cpp
Committed r41437