Bug 243562
| Summary: | Make '-webkit-background-size' a legacy shorthand | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> |
| Component: | Forms | Assignee: | Aditya Keerthi <akeerthi> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | akeerthi, cdumez, ntim, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 240341 | ||
Tim Nguyen (:ntim)
This test checks that setting various properties to the same value as the user agent stylesheet does not change the appearance.
We fail this check, potentially because our borderAndBackgroundEquals check does not cover enough properties.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/98151497>
Aditya Keerthi
One of the issues is: https://github.com/web-platform-tests/wpt/issues/35333.
The other issue is that the list of "fallback-props" in https://github.com/web-platform-tests/wpt/blob/19d452e70a/css/css-ui/compute-kind-widget-no-fallback-props-001.html, does not include `-webkit-background-size`, in addition to `background-size`, causing the `borderAndBackgroundEquals` check to fail, dropping native appearance.
The test and the spec likely need to be updated.
Tim Nguyen (:ntim)
(In reply to Aditya Keerthi from comment #2)
> The other issue is that the list of "fallback-props" in
> https://github.com/web-platform-tests/wpt/blob/19d452e70a/css/css-ui/compute-
> kind-widget-no-fallback-props-001.html, does not include
> `-webkit-background-size`, in addition to `background-size`, causing the
> `borderAndBackgroundEquals` check to fail, dropping native appearance.
The proper way to fix this would be making `-webkit-background-size` a legacy shorthand of `background-size` rather than implementing it as a related property. An example of this is bug 104805.
Tim Nguyen (:ntim)
WPT PR: https://github.com/web-platform-tests/wpt/pull/35408
Aditya Keerthi
I have a patch in progress to make `-webkit-background-size` a legacy shorthand. This actually makes appearance behave correctly, however, the test still fails.
We will also need to fix the intrinsic margins issue (https://bugs.webkit.org/show_bug.cgi?id=107380) in order to get this test passing.
I confirmed that with my background-size patch, and with Chris' patch in https://bugs.webkit.org/show_bug.cgi?id=107380, this test finally passes.
Aditya Keerthi
Pull request: https://github.com/WebKit/WebKit/pull/3372
EWS
Committed 254925@main (856140e9a06f): <https://commits.webkit.org/254925@main>
Reviewed commits have been landed. Closing PR #3372 and removing active labels.