Bug 243499 – [LBSE] Add support for 'image' elements

• Component: SVG
• Status: RESOLVED FIXED

[Nikolas Zimmermann]

Add support for the last missing SVG element, that is not a resource (pattern / gradient / clipPath / masker / marker): <image>.

[Radar WebKit Bug Importer]

<rdar://problem/98457550>

[Nikolas Zimmermann]

Pull request: https://github.com/WebKit/WebKit/pull/3532

[EWS]

Committed 253793@main (4b8776daaa57): <https://commits.webkit.org/253793@main>

Reviewed commits have been landed. Closing PR #3532 and removing active labels.

[Michael Catanzaro]

Hi Nikolas, can you fix this warning please?

[1118/2033] Building CXX object Source/WebCore/CMakeFiles/...ivedSources/unified-sources/UnifiedSource-8feba646-9.cpp.o
In file included from /home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk3/WebCore/DerivedSources/unified-sources/UnifiedSource-8feba646-9.cpp:2:
/home/mcatanzaro/Projects/WebKit/Source/WebCore/svg/SVGImageElement.cpp: In member function ‘virtual void WebCore::SVGImageElement::svgAttributeChanged(const WebCore::QualifiedName&)’:
/home/mcatanzaro/Projects/WebKit/Source/WebCore/svg/SVGImageElement.cpp:113:23: warning: unused variable ‘image’ [-Wunused-variable]
  113 |             if (auto* image = dynamicDowncast<RenderSVGImage>(renderer()))
      |                       ^~~~~

I'm not certain whether you want to do:

#if ENABLE(LAYER_BASED_SVG_ENGINE)
            if (dynamicDowncast<RenderSVGImage>(renderer()))
                updateSVGRendererForElementChange();
#endif

Or whether you want to do:

#if ENABLE(LAYER_BASED_SVG_ENGINE)
            updateSVGRendererForElementChange();
#endif

So I'll just leave it to you, OK?