Summary: | Remove Gears workaround in HTMLObjectElement.cpp | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jeremy Moskovich <playmobil> | ||||
Component: | Plug-ins | Assignee: | Jeremy Moskovich <playmobil> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, dglazkov, eric, jorlow, simon.fraser | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | 27775, 45049 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Jeremy Moskovich
2009-03-04 02:02:58 PST
What's the status here? This code is still in the codebase. The plan is to make plugins not go away when an element has display:none. Not sure if we have a bugzilla bug on that. Created attachment 75005 [details]
Patch
Comment on attachment 75005 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75005&action=review I think we can safely remove the entire rendererIsNeeded() call. I don't see any parent implementations preventing creation of renderers when a document doesn't have a frame, but I believe that to be the case. Frameless documents won't have a FrameView, thus won't be rendered is my understanding. I think this whole override can be removed unless we have a test which proves otherwise. > WebCore/html/HTMLObjectElement.cpp:289 > if (!frame) > return false; Are we sure this is still needed? I'd rather see you commit this by hand and remove the whole function (or post a new patch to do so). I don't believe the !frame check has any utility. I'm not familiar with the surrounding code, I'm just removing the workaround I put in. I'd prefer for more ambitious cleanups to be done by other people who have better knowledge of the area. Does that sound OK? Comment on attachment 75005 [details] Patch Clearing flags on attachment: 75005 Committed r72799: <http://trac.webkit.org/changeset/72799> All reviewed patches have been landed. Closing bug. I'm confused. Bug 27775 is not fixed. Was Gears changed to avoid this issue? |