Bug 24327

Summary:

Fix hit testing on elements running accelerated transform animations

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Layout and Rendering

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarrin

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

23359

Attachments:

Description	Flags
Patch, changelog	eric: review-
Revised patch	hyatt: review+

Description Simon Fraser (smfr) 2009-03-03 10:12:40 PST

In implementing 3d hit testing, I broke the hit testing on elements running accelerated animations. This needs to be fixed in a more central location.

Comment 1 Simon Fraser (smfr) 2009-03-04 15:26:31 PST

Created attachment 28287 [details]
Patch, changelog

Comment 2 Eric Seidel (no email) 2009-03-04 17:27:41 PST

Comment on attachment 28287 [details]
Patch, changelog

Since you never seem to use the "has a transform" bool return, why not just have it return a TransformationMatrix object instead of passing one by reference?  Seems cleaner to return one to me.

Otherwise looks fine.  You should add a comment to the ChangeLog that the test case in question only fails when ACCELLERATED_COMPOSITING is turned on.

Comment 3 Simon Fraser (smfr) 2009-03-04 18:32:46 PST

Created attachment 28296 [details]
Revised patch

Comment 4 Dave Hyatt 2009-03-05 11:09:12 PST

Comment on attachment 28296 [details]
Revised patch

r=me

Comment 5 Simon Fraser (smfr) 2009-03-05 11:40:11 PST

http://trac.webkit.org/changeset/41455