Summary: | Make DOMTimer clamp adjustable via settings | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mike Belshe <mbelshe> | ||||||||
Component: | WebCore Misc. | Assignee: | David Levin <levin> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | ||||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Mike Belshe
2009-03-03 09:43:10 PST
Created attachment 28225 [details]
patch
Comment on attachment 28225 [details]
patch
I think you need a comment explaining why a #define is being used. It's ok to mention that Chromium has no clamp in the comment. We need to make sure people know why this oddity is here, since otherwise they might just yank the code.
Also need a ChangeLog comment.
Created attachment 28327 [details]
New patch, using C++ accessors
Comment on attachment 28327 [details]
New patch, using C++ accessors
We use "s_" for statics, so this should be s_minTimerInterval. Other than that, it looks fine.
Created attachment 28529 [details]
change m_minTimerInterval to s_minTimerInterval
r=me, given that hyatt already reviewed the substance of the patch. Assign to levin for landing. Please add a link the bug in the ChangeLog in the future. |