Bug 243221
| Summary: | [XCBuild] Legacy build system cleanup | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Elliott Williams <emw> |
| Component: | Tools / Tests | Assignee: | Elliott Williams <emw> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | achristensen, commit-queue, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 253301 | ||
| Bug Blocks: | |||
Elliott Williams
There are a number of build settings, script phases, and workarounds which only existed to support the legacy build system. Let's clean them up.
For the most part, this can be done by finding usage of WK_WHICH_BUILD_SYSTEM and WK_USE_NEW_BUILD_SYSTEM in xcconfigs and script phases, and deleting the legacy code path.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/2745
Elliott Williams
rdar://89701972
Radar WebKit Bug Importer
<rdar://problem/97618431>
EWS
Committed 252870@main (f5950aef5b7e): <https://commits.webkit.org/252870@main>
Reviewed commits have been landed. Closing PR #2745 and removing active labels.
Alex Christensen
Reverting in https://bugs.webkit.org/show_bug.cgi?id=243259 because it broke the iOS build
make release ARCHS=arm64e SDKROOT=iphoneos.internal
Alex Christensen
Reverted by https://github.com/WebKit/WebKit/pull/2787
EWS
Committed 252875@main (a790b3beee52): <https://commits.webkit.org/252875@main>
Reviewed commits have been landed. Closing PR #2787 and removing active labels.
Elliott Williams
Re-opening for pull request https://github.com/WebKit/WebKit/pull/10552
EWS
merge-queue failed to commit PR to repository. To retry, remove any blocking labels and re-apply merge-queue label
EWS
Committed 261111@main (91b246244bf1): <https://commits.webkit.org/261111@main>
Reviewed commits have been landed. Closing PR #10552 and removing active labels.
WebKit Commit Bot
Re-opened since this is blocked by bug 253301
Alexey Proskuryakov
rdar://89701972
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/12010
EWS
Committed 262162@main (ecef01756ff9): <https://commits.webkit.org/262162@main>
Reviewed commits have been landed. Closing PR #12010 and removing active labels.
Elliott Williams
Reopening to fix some additional places where these variables are used.
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/12125
EWS
Committed 262287@main (dbd94e530aea): <https://commits.webkit.org/262287@main>
Reviewed commits have been landed. Closing PR #12125 and removing active labels.