Summary: | Add V8 bindings headers | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||
Component: | WebCore Misc. | Assignee: | Dimitri Glazkov (Google) <dglazkov> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Dimitri Glazkov (Google)
2009-03-03 09:04:26 PST
Created attachment 28223 [details]
Add V8 bindings headers
WebCore/ChangeLog | 22 ++++++
WebCore/bindings/v8/V8Binding.h | 75 +++++++++++++++++++
WebCore/bindings/v8/V8Proxy.h | 79 ++++++++++++++++++++
WebCore/bindings/v8/custom/V8CustomBinding.h | 38 ++++++++++
WebCore/bindings/v8/custom/V8CustomEventListener.h | 38 ++++++++++
5 files changed, 252 insertions(+), 0 deletions(-)
Comment on attachment 28223 [details] Add V8 bindings headers >+++ b/WebCore/ChangeLog ... >+ * bindings/v8/V8Binding.h: Added. >+ (WebCore::toInt32): >+ (WebCore::toFloat): >+ (WebCore::toWebCoreString): >+ (WebCore::toWebCoreStringWithNullCheck): >+ (WebCore::isUndefinedOrNull): >+ (WebCore::v8Boolean): >+ * bindings/v8/V8Proxy.h: Added. >+ (WebCore::notHandledByInterceptor): >+ (WebCore::deletionNotHandledByInterceptor): >+ (WebCore::throwError): >+ (WebCore::toV8): >+ * bindings/v8/custom/V8CustomBinding.h: Added. >+ * bindings/v8/custom/V8CustomEventListener.h: Added. nit: remove the functions listed by prepare-ChangeLog for newly added files. >+++ b/WebCore/bindings/v8/V8Binding.h ... >+ // FIXME: Rename valueToStringWithNullCheck once migration is complete >+ inline String toWebCoreStringWithNullCheck(v8::Handle<v8::Value> value) nit: indentation OK, LGTM Landed as http://trac.webkit.org/changeset/41394. |