Bug 24307

Summary:

m_highlightedNode should be cleared on hideHighlight

Product:

WebKit

Reporter:

Ojan Vafai <ojan>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Null m_highlightedNode on hideHighlight()	adele: review+

Description Ojan Vafai 2009-03-02 16:50:46 PST

This makes it consistent with setting it on highlight(). More importantly, the chromium build relies on the null-check at the beginning of drawNodeHighlight as to whether to draw the node highlight.

Comment 1 Ojan Vafai 2009-03-02 17:34:54 PST

Created attachment 28208 [details]
Null m_highlightedNode on hideHighlight()

 WebCore/ChangeLog                         |   11 +++++++++++
 WebCore/inspector/InspectorController.cpp |    1 +
 2 files changed, 12 insertions(+), 0 deletions(-)

Comment 2 Eric Seidel (no email) 2009-03-02 18:13:02 PST

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/InspectorController.cpp
Committed r41377