Bug 242597

Summary:	[Make] Can't set GCC_PREPROCESSOR_ADDITIONS since 252143@main
Product:	WebKit	Reporter:	Elliott Williams <emw>
Component:	Tools / Tests	Assignee:	Elliott Williams <emw>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Elliott Williams

Reported 2022-07-11 11:39:26 PDT

https://commits.webkit.org/252143@main ("Stop passing build settings on the command line to avoid invalidating IDE builds") broke workflows where GCC_PREPROCESSOR_ADDITIONS is set from outside of the Makefile (like in `build-jsc`).

Attachments
Add attachment proposed patch, testcase, etc.

Elliott Williams

Comment 1 2022-07-11 11:46:55 PDT

Pull request: https://github.com/WebKit/WebKit/pull/2296

EWS

Comment 2 2022-07-11 12:49:05 PDT

Committed 252348@main (ab59fcd01122): <https://commits.webkit.org/252348@main> Reviewed commits have been landed. Closing PR #2296 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2022-07-11 12:50:19 PDT

<rdar://problem/96838065>

Note You need to log in before you can comment on or make changes to this bug.