Bug 24254

Summary: [GTK] spacebar doesn't scroll down
Product: WebKit Reporter: Emilio Pozuelo Monfort <pochu27>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
proposed fix
none
proposed fix
none
makes space scroll down, and shift+space scroll up alp: review+

Emilio Pozuelo Monfort
Reported 2009-02-27 16:05:26 PST
Pressing space on webkit should scroll down the webview, but for the GTK port it doesn't.
Attachments
proposed fix (1.97 KB, patch)
2009-03-11 20:34 PDT, Gustavo Noronha (kov) 		no flags
DetailsFormatted DiffDiff
proposed fix (1.98 KB, patch)
2009-03-12 05:17 PDT, Gustavo Noronha (kov) 		no flags
DetailsFormatted DiffDiff
makes space scroll down, and shift+space scroll up (2.00 KB, patch)
2009-03-12 06:05 PDT, Gustavo Noronha (kov) 		alp: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2009-03-11 20:34:37 PDT
Created attachment 28518 [details] proposed fix It seems to me like we should look forward to do some rework on our scrolling code as a whole. I know Xan has been doing an awesome work on this front, but maybe we need to look at the big picture a bit more.
Gustavo Noronha (kov)
Comment 2 2009-03-12 05:17:33 PDT
Created attachment 28524 [details] proposed fix Addressing comments by alp and xan on IRC.
Gustavo Noronha (kov)
Comment 3 2009-03-12 06:05:56 PDT
Created attachment 28526 [details] makes space scroll down, and shift+space scroll up Addressed more comments by Xan on IRC.
Alp Toker
Comment 4 2009-03-12 06:12:29 PDT
Comment on attachment 28526 [details] makes space scroll down, and shift+space scroll up r=me but please fix the ChangeLog entry to not mention backspace
Gustavo Noronha (kov)
Comment 5 2009-03-12 06:22:57 PDT
Landed as r41622.
Note You need to log in before you can comment on or make changes to this bug.