Bug 24251

Summary:

Cleanup: replace positionForCoordinates with positionForPoint

Product:

WebKit

Reporter:

Ojan Vafai <ojan>

Component:

Layout and Rendering

Assignee:

Ojan Vafai <ojan>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Replace positionForCoordinates with positionForPoint.	eric: review+

Description Ojan Vafai 2009-02-27 14:43:28 PST

There seemed to be general agreement on #webkit that positionforPoint is preferable. Making this change in preparation for removing positionForPoint from RenderText and fixing bug 24180.

Comment 1 Ojan Vafai 2009-02-27 16:34:54 PST

Created attachment 28106 [details]
Replace positionForCoordinates with positionForPoint.

 WebCore/ChangeLog                         |   38 +++++++++++++++++++++++++++++
 WebCore/page/Frame.cpp                    |    2 +-
 WebCore/rendering/RenderBR.cpp            |    2 +-
 WebCore/rendering/RenderBR.h              |    2 +-
 WebCore/rendering/RenderBlock.cpp         |   14 +++++-----
 WebCore/rendering/RenderBlock.h           |    2 +-
 WebCore/rendering/RenderBox.cpp           |    7 ++++-
 WebCore/rendering/RenderBox.h             |    2 +-
 WebCore/rendering/RenderInline.cpp        |   10 ++++----
 WebCore/rendering/RenderInline.h          |    2 +-
 WebCore/rendering/RenderObject.cpp        |    8 +++---
 WebCore/rendering/RenderObject.h          |    4 +-
 WebCore/rendering/RenderReplaced.cpp      |   10 ++++----
 WebCore/rendering/RenderReplaced.h        |    2 +-
 WebCore/rendering/RenderSVGInlineText.cpp |    4 +-
 WebCore/rendering/RenderSVGInlineText.h   |    2 +-
 WebCore/rendering/RenderText.cpp          |   22 ++++++++--------
 WebCore/rendering/RenderText.h            |    2 +-
 WebKit/mac/WebView/WebFrame.mm            |   14 +---------
 19 files changed, 90 insertions(+), 59 deletions(-)

Comment 2 Eric Seidel (no email) 2009-02-27 17:12:07 PST

Comment on attachment 28106 [details]
Replace positionForCoordinates with positionForPoint.

Looks good.  "Existing tests presumably cover the relevant edge-cases here." There are no edge cases to cover! :)  So no need for that line.

Comment 3 David Levin 2009-03-01 16:43:34 PST

Committed as r41347.