Bug 242353

Summary: Add const to some fields that are meant to be immutable after construction.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
EWS testing.
none
Test for gtk EWS. none

Mark Lam
Reported 2022-07-05 12:30:57 PDT
This helps provides a hint to the compiler that a previously fetched constant field need not be re-fetched. Secondly, it documents for the reader that the intention that the field will not change after construction.
Attachments
EWS testing. (33.86 KB, patch)
2022-07-05 17:14 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
Test for gtk EWS. (600 bytes, patch)
2022-07-05 19:21 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2022-07-05 12:34:17 PDT
Pull request: https://github.com/WebKit/WebKit/pull/2086
Mark Lam
Comment 2 2022-07-05 17:14:46 PDT
Created attachment 460695 [details] EWS testing.
Mark Lam
Comment 3 2022-07-05 19:21:03 PDT
Created attachment 460700 [details] Test for gtk EWS.
EWS
Comment 4 2022-07-05 20:36:25 PDT
Committed 252168@main (7433e6a2671b): <https://commits.webkit.org/252168@main> Reviewed commits have been landed. Closing PR #2086 and removing active labels.
Radar WebKit Bug Importer
Comment 5 2022-07-05 20:37:14 PDT
<rdar://problem/96489199>
Note You need to log in before you can comment on or make changes to this bug.