Bug 242318
| Summary: | git-webkit upload should amend the commit instead of making a new commit | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ap, jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=240607 | ||
| Bug Depends on: | |||
| Bug Blocks: | 239082 | ||
Ryosuke Niwa
git-webkit upload should amend the commit instead of trying to create a new commit in each invocation.
Looks like this option exists but not enabled by default? --amend.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
There isn't consensus on the right behavior yet - some people prefer additional changes to be separate commits to make reviewing easier. And then squash before landing.
Ryosuke Niwa
(In reply to Alexey Proskuryakov from comment #1)
> There isn't consensus on the right behavior yet - some people prefer
> additional changes to be separate commits to make reviewing easier. And then
> squash before landing.
Maybe this should be configurable during setup?
Radar WebKit Bug Importer
<rdar://problem/96837043>
Ryosuke Niwa
So... apparently merge-queue can't land a PR unless all commits are squashed so the current behavior of git-webkit upload is incompatible with merge queue.