Bug 242209

Summary: Remove GraphicsLayer::supportsRoundedClip and RenderLayerBacking::m_childClippingMaskLayer
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: CompositingAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, darin, esprehn+autocc, ews-watchlist, fred.wang, glenn, jenner, kondapallykalyan, pdr, sergio, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=242832
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2022-06-30 14:50:43 PDT
After 252014@main (bug#242097), GraphicsLayer::supportsRoundedClip returns true for all ports. We can remove it.
Attachments
Patch (12.15 KB, patch)
2022-06-30 14:55 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2022-06-30 14:55:57 PDT
Created attachment 460589 [details] Patch
EWS
Comment 2 2022-07-01 14:06:19 PDT
Committed 252070@main (c1a2e7ae525f): <https://commits.webkit.org/252070@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460589 [details].
Radar WebKit Bug Importer
Comment 3 2022-07-01 14:07:13 PDT
<rdar://problem/96313350>
Robert Jenner
Comment 4 2022-07-15 23:42:59 PDT
I am re-opening this bug because I had to do a partial revert of 25070@main. The changes committed to updateGeometry at that change caused testing on iOS 16 Debug beta to crash and never complete. I added the crashlog text to this bug: https://bugs.webkit.org/show_bug.cgi?id=242832 Additionally I added the revert needed to that bug, and it is currently going through testing.
Fujii Hironori
Comment 5 2022-07-16 05:52:44 PDT
I can't believe. My change just removed unused code. I should have no effect.
Darin Adler
Comment 6 2022-07-16 14:27:10 PDT
I agree. This doesn’t make logical sense.
Fujii Hironori
Comment 7 2022-07-19 20:39:06 PDT
bug#242832 was resolved. Closed this bug again.
Note You need to log in before you can comment on or make changes to this bug.