Bug 242112 – [LFC][FFC] Add support for non-stretching flex items with flex-basis

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

where flex-basis != logical width

[alan]

Created attachment 460543 [details]
Patch

[Tim Nguyen (:ntim)]

Comment on attachment 460543 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460543&action=review

> Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:232
> +                auto flexedSize = reolvedFlexItem.flexBasis + reolvedFlexItem.flexGrow * flexGrowBase;
> +                if (flexedSize && reolvedFlexItem.minimumSize >= flexedSize) {
> +                    reolvedFlexItem.isFrozen = true;
>                      didFreeze = true;
> -                    totalGrowth -= stretchingFlex.flexGrow;
> -                    totalFlexibleSpace -= stretchingFlex.flexBasis;
> -                    availableSpace -= stretchingFlex.minimumSize;
> +                    totalGrowth -= reolvedFlexItem.flexGrow;
> +                    totalFlexibleSpace -= reolvedFlexItem.flexBasis;
> +                    availableSpace -= reolvedFlexItem.minimumSize;
>                  }

typo: reolved

[alan]

Created attachment 460629 [details]
Patch

[EWS]

Committed 252087@main (02229f46cd9b): <https://commits.webkit.org/252087@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460629 [details].

[Radar WebKit Bug Importer]

<rdar://problem/96330047>