Bug 24210

Summary: Improvements to autotools configuration of the build script
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: WebKit Misc.Assignee: Gustavo Noronha (kov) <gustavo>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Gtk
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
adds option to enable gnome keyring
zecke: review+
adds a new environment variable to enable passing arguments to make zecke: review+

Gustavo Noronha (kov)
Reported 2009-02-26 15:27:48 PST
The script doesn't allow us to enable GNOME Keyring, and passing arguments such as -j to the call to make. I suggest we add both =).
Attachments
adds option to enable gnome keyring (3.60 KB, patch)
2009-02-26 15:28 PST, Gustavo Noronha (kov) 		zecke: review+
DetailsFormatted DiffDiff
adds a new environment variable to enable passing arguments to make (1.47 KB, patch)
2009-02-26 15:30 PST, Gustavo Noronha (kov) 		zecke: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2009-02-26 15:28:35 PST
Created attachment 28044 [details] adds option to enable gnome keyring
Gustavo Noronha (kov)
Comment 2 2009-02-26 15:30:08 PST
Created attachment 28045 [details] adds a new environment variable to enable passing arguments to make
Holger Freyther
Comment 3 2009-03-01 07:14:51 PST
Comment on attachment 28044 [details] adds option to enable gnome keyring > @@ -70,7 +71,7 @@ Usage: $programName [options] [options to pass to build system] > --cairo-win32 Build using Cairo (rather than CoreGraphics) on Windows > --chromium Build the Chromium port on Mac/Win/Linux > --clean Cleanup the build directory > - --gtk Build the GTK port > + --gtk Build the GTK+ port make this a separate commit (rs=me on this).
Holger Freyther
Comment 4 2009-03-01 07:16:38 PST
Comment on attachment 28045 [details] adds a new environment variable to enable passing arguments to make hmmm... okay... unlikely to break someone else ports and it is unlikely that we see breakage from that (shell and quotes always make me nervous).
Gustavo Noronha (kov)
Comment 5 2009-03-01 10:23:45 PST
Landed as r41327 and r41328.
Note You need to log in before you can comment on or make changes to this bug.